✅ Deploy Preview for inventree-web-pui-preview ready!

Name	Link
🔨 Latest commit	182ed35
🔍 Latest deploy log	https://app.netlify.com/projects/inventree-web-pui-preview/deploys/69b9254cc518a60008fd275b
😎 Deploy Preview	https://deploy-preview-11074--inventree-web-pui-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 86 (🔴 down 8 from production) Accessibility: 81 (no change from production) Best Practices: 100 (no change from production) SEO: 78 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Ok, I've rewrited it a little. What about now? Calling method is gone. I had to still leave there some parameter passing because I didn't figured out how to hide this field in edit forms in some other way.

The button should not be within the form itself - place it down in the bottom bar:

Ok, I now rewritted it as a form property, enabled on create forms.

@spamik it looks like your current implementation does not actually use the "keep open" feature in any forms yet - is this intentional?

@SchrodingersGat It shouldn't be; I added keepFormOpenOption=true to CreateApiModalForm so this option should be visible on all create forms (and at least it looks like that when I was testing it). But it's for sure possible to change this option on create form and enable it only on specific forms.

Please address this issue:

8:16:46 PM: $ tsc && vite build --emptyOutDir --outDir dist
8:16:56 PM: src/components/forms/ApiForm.tsx(136,9): error TS2353: Object literal may only specify known properties, and 'field_name' does not exist in type '{ field: ApiFormFieldType; definition?: ApiFormFieldType | undefined; }'.
8:16:56 PM: error Command failed with exit code 2. (https://ntl.fyi/exit-code-2)

@spamik I have pulled this code branch down to test, and I notice a real performance hit when toggling the "keep form open" switch.

When compared to a normal boolean input within the form (which toggles very quickly) there is a significant slow-down / lag which is introduced into the browser - especially when quickly toggling the "keep form open" input multiple times.

I have not had a chance to try to profile this yet, but this will need to be addressed before we can merge.

I'll try to look on both of the issues.

Regarding the performance hit - any idea from experienced react developers what can cause it? Because I've just used mantis switch component and on onchange event it's changing boolean property so I'm really wondering what can be wrong with this part :-)

Another consideration here - I do not think that adding this button should be the default option. I have found a number of dialogs where it certainly does not make sense:

So, we should make it opt-in and decide where it is actually useful!

Typescript error fixed. Also I've removed this option as default and I've enabled it on some selected forms which seems reasonable for this option to me.

I've made some other changes - switch with option was moved to component. And rewrited useState to useRef instead. Now when I'm trying to clicking on switch fast it seems that it's performing much better.

@spamik very nice, happy with this now! Just some very small changes to request:

Changelog

• Can you please add a brief entry into ./CHANGELOG.md into the Added section for the upcoming release?

Docs

• Please add a brief description (and a screenshot) to the "forms" section in ./docs/docs/concepts/user_interface.md

Done :-)

@spamik thanks!

One last thing (sorry!) - I note that there are no test added for this new feature - can you please add a playwright test to ensure that it is functioning as expected:

https://docs.inventree.org/en/stable/develop/react-frontend/#testing

Please add a test, fix conflicts, and I'm happy to merge this in!

Yep, I'll try that. Maybe it will take a little time - playwright is another technology I didn't used so far :-)